Skip to content

Remove unused getDylinkMetadata in wasm_patches #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Jun 6, 2025

Description

Please include a summary of changes, motivation and context for this PR.

If you look here https://github.com/compiler-research/xeus-cpp/actions/runs/15491557309/job/43618050719#step:5:192 , you'll see that the Emscripten build of xeus-cpp has the following warning

warning: invalid item in EXPORTED_RUNTIME_METHODS: getDylinkMetadata

This means we are not using this part of the wasm_patches, so can be removed.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (2226ca0) to head (7f75a42).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491
Copy link
Collaborator

Hmm, I think this is needed somewhere

Cc @martinRenou

@anutosh491
Copy link
Collaborator

anutosh491 commented Jun 6, 2025

As you can probably see this log still appears in the Ci which confirms its coming from the xeus side. I don't think any change would be needed on xeus-cpp's side to address this (even if it needs addressing... I forget where exactly this was playing a part)

@anutosh491
Copy link
Collaborator

Hi,

I don't think anything needs to be changed on the xeus-cpp side to address this (if even it needs addressing in the first place). As can be seen the error/warning can still be seen in the build.

Feel free to look into xeus/jupyterlite-xeus if you are trying to address this. Closing.

@anutosh491 anutosh491 closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants