Remove unused getDylinkMetadata in wasm_patches #338
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
If you look here https://github.com/compiler-research/xeus-cpp/actions/runs/15491557309/job/43618050719#step:5:192 , you'll see that the Emscripten build of xeus-cpp has the following warning
warning: invalid item in EXPORTED_RUNTIME_METHODS: getDylinkMetadata
This means we are not using this part of the wasm_patches, so can be removed.
Fixes # (issue)
Type of change
Please tick all options which are relevant.