Skip to content

Commit

Permalink
attempt to fix csv writing on cordova by replacing streaming
Browse files Browse the repository at this point in the history
This is an attempt to fix duplicate headers in the csv export.

It replaces the node stream functionality with simple string writing,
and uses papa parse instead of constructing the csv manually.

It doesn't seem to work!
  • Loading branch information
jthrilly committed Dec 1, 2023
1 parent 26dde0f commit 99b53eb
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 6 deletions.
9 changes: 6 additions & 3 deletions config.xml
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<widget android-versionCode="6388" id="org.codaco.NetworkCanvasInterviewer6" ios-CFBundleIdentifier="org.codaco.networkCanvasInterviewerBusiness" ios-CFBundleVersion="6388" version="6.5.1" xmlns="http://www.w3.org/ns/widgets" xmlns:android="http://schemas.android.com/apk/res/android" xmlns:cdv="http://cordova.apache.org/ns/1.0">
<widget android-versionCode="6388" id="org.codaco.NetworkCanvasInterviewer6" ios-CFBundleIdentifier="org.codaco.networkCanvasInterviewerBusiness" ios-CFBundleVersion="6388" version="6.5.1"
xmlns="http://www.w3.org/ns/widgets"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:cdv="http://cordova.apache.org/ns/1.0">
<name>Network Canvas Interviewer</name>
<description>
A tool for conducting Network Canvas Interviews.
</description>
<author email="[email protected]" href="http://coda.co">
Complex Data Collective
</author>
<content src="index.html"/>
<content src="http://192.168.1.210:3000/"/>
<access origin="*"/>
<access origin="cdvfile://*"/>
<allow-intent href="http://*/*"/>
Expand Down Expand Up @@ -84,4 +87,4 @@
<plugin name="cordova-plugin-network-information" spec="~2.0.2"/>
<plugin name="cordova-plugin-chooser" spec="~1.3.1"/>
<plugin name="cordova-sqlite-storage" spec="6.0.0"/>
</widget>
</widget>
4 changes: 1 addition & 3 deletions config/nc-dev-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,7 @@ const devServerContentBase = () => {
};

// Webpack default is 'web'. To get electron working with dev server, use 'electron-renderer'.
// const reactBundleTarget = () => (isTargetingElectron ? 'electron-renderer' : 'web');

const reactBundleTarget = () => 'web';
const reactBundleTarget = () => (isTargetingElectron ? 'electron-renderer' : 'web');

module.exports = {
cleanDevUrlFile,
Expand Down
11 changes: 11 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@
"d3-force": "~3.0.0",
"dmg-builder": "~23.6.0",
"electron-devtools-installer": "^3.0.0",
"papaparse": "~5.4.1",
"xcode": "~3.0.1",
"zeroconf": "^0.1.4"
},
Expand Down

0 comments on commit 99b53eb

Please sign in to comment.