Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crow/0.1 #3123

Merged
merged 12 commits into from
Oct 21, 2020
Merged

Crow/0.1 #3123

merged 12 commits into from
Oct 21, 2020

Conversation

madduci
Copy link
Contributor

@madduci madduci commented Oct 6, 2020

crow/0.1

closes #3064

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 1 (2fe1f7cbfc677336c010aa47cdd329c42ddcc0e9):

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 4 (4b6adf405cf4eb9db1450300f7c47379a2691aac):

@conan-center-bot
Copy link
Collaborator

Failure in build 5 (df565c5fbd2e64cd0d4ab3a87e447609895317ff):

  • crow/0.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [NO FINAL ENDLINE (KB-H041)] File '/home/conan/w/cci_PR-3123/recipes/crow/all/test_package/CMakeLists.txt' does not end with an endline (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H041)

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 6 (847d993d9685be99f3cb672c875c71220bb70c24):

@conan-center-bot
Copy link
Collaborator

Failure in build 7 (d1e1c65e98db50c7fd8268593768c31d6a1bc80e):

  • Error processing recipe (ref 'crow/0.1'): Linux x86_64, Release, gcc 4.9, libstdc++
    You are depending on 'boost/1.60.0' but it is not in the repository

@madduci
Copy link
Contributor Author

madduci commented Oct 7, 2020

This library seems to not work with modern Boost (>=1.70.0), due to removal/deprecation of some methods in boost::asio. I'm trying with the oldest Boost possible available in the conan center, which is 1.69.0

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 8 (97f744def3341f8b40f09fae726f063e32e62098):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 9 (8becd811c976d70cf955090ed065beec1a03397f):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 10 (0e152579e0ade04757fa804675f7e140e3be9851):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 11 (fd8672f8908c8872449ff10a325f5eb86e0ccc68):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 12 (bffddb770d84dacd3738394508e6f4b2782af33f):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 13 (af981afac97aaac7f4fcfbb5af8ff1b5ee57293e):

  • Linux x86_64, Release, gcc 4.9, libstdc++
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Empty package (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=Linux, compiler=gcc (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H014)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

All green in build 14 (91a5a89f5c7a3b5286ddf300b4f9c762c28057e7)! 😊

@conan-center-bot
Copy link
Collaborator

Some configurations of 'crow/0.1' failed in build 16 (8605a6d7a26f477c2751c1dc0aba76b33c85b681):

@prince-chrismc
Copy link
Contributor

Sure, I am happy to add the raising of error if the version is too high, but is there actually a way to check which version of boost is being consumed, within the conanfile.py? Sorry for the question, but I don't know all the Conan internals and possibilities as you do.

I did not know how either but I found this

packio_version = self.deps_cpp_info["packio"].version
searching the repo! let me know how it goes

About the forced C++ version, I can remove the flag, but beware the code seems to be unmaintained since 2017, I don't know if there's some template magic that might be broken with newer or older C++ standards

I think we should let the CCI team answer... I suspect other projects may override the cppstd settings and doing so here is fine.

PS. templates are not magic! It's a very uncommon lesser known science which only obscure YouTube video teach the subject 😝

@conan-center-bot
Copy link
Collaborator

All green in build 17 (045f3f159e7132e5b4302f3269c579afa73c27ef)! 😊

Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Copy link
Member

@madduci Consider https://github.com/madduci/conan-center-index/pull/1

@conan-center-bot
Copy link
Collaborator

All green in build 18 (6b5fc69dd6b6e6933617eb9fc3190ad635b76491)! 😊

uilianries
uilianries previously approved these changes Oct 9, 2020
prince-chrismc
prince-chrismc previously approved these changes Oct 10, 2020
@SSE4 SSE4 requested a review from danimtb October 12, 2020 10:27
@prince-chrismc prince-chrismc mentioned this pull request Oct 13, 2020
4 tasks
recipes/crow/all/conandata.yml Outdated Show resolved Hide resolved
recipes/crow/all/conanfile.py Outdated Show resolved Hide resolved
recipes/crow/all/conanfile.py Outdated Show resolved Hide resolved
@madduci madduci dismissed stale reviews from prince-chrismc and uilianries via 996c5a2 October 21, 2020 03:46
@conan-center-bot
Copy link
Collaborator

All green in build 19 (996c5a28e42ccc0763990b41002366d02ba8dd3c)! 😊

@Croydon Croydon mentioned this pull request Oct 21, 2020
@conan-center-bot conan-center-bot merged commit e400419 into conan-io:master Oct 21, 2020
@madduci madduci deleted the crow/0.1 branch October 22, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] crow/0.1
7 participants