Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adapt plugin colors to selected theme #237

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Fix: Adapt plugin colors to selected theme #237

merged 5 commits into from
Jun 19, 2024

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Jun 18, 2024

Closes: #229

image

image

Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

purple buttons huh? 🤨 hahaha. Looks good to me!

@czoido
Copy link
Contributor Author

czoido commented Jun 19, 2024

purple buttons huh? 🤨 hahaha. Looks good to me!

Yes! 😄 because I could not manage to change the icons color dynamically 🙄, I finally put it to medium gray that also contrasts with both themes dark and light

Resources/icons.xaml Outdated Show resolved Hide resolved
@czoido czoido merged commit 31ef223 into develop2 Jun 19, 2024
3 checks passed
@czoido czoido deleted the fix-dark-theme branch June 19, 2024 04:50
@czoido czoido added this to the 2.0.3 milestone Jun 19, 2024
@czoido czoido changed the title Fix colors for dark theme Fix: Adapt plugin colors to selected theme Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor contrast in tool window when using VS Dark theme
3 participants