Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative path for CMAKE_INSTALL_LIBDIR #63

Merged

Conversation

robertmaynard
Copy link
Contributor

The CMAKE_INSTALL_LIBDIR needs to be relative for the CCCL-config.cmake packaged with librmm to work properly.

This is exactly what the upstream rapidsai version of librmm does ( https://github.com/rapidsai/rmm/blob/branch-24.04/conda/recipes/librmm/build.sh#L3 )

Checklist

Sorry, something went wrong.

The `CMAKE_INSTALL_LIBDIR` needs to be relative for the
CCCL-config.cmake packaged with librmm to work properly.

This is exactly what the upstream rapidsai version
of librmm does.
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@kkraus14
Copy link
Contributor

The CMAKE_INSTALL_LIBDIR needs to be relative for the CCCL-config.cmake packaged with librmm to work properly

We can make the change here, but this seems like a bug in the CCCL-config.cmake? Can this be fixed upstream as well?

@robertmaynard
Copy link
Contributor Author

The CMAKE_INSTALL_LIBDIR needs to be relative for the CCCL-config.cmake packaged with librmm to work properly

We can make the change here, but this seems like a bug in the CCCL-config.cmake? Can this be fixed upstream as well?

Absolute values for CMAKE_INSTALL_LIBDIR aren't truly fully supported by cmake, since the cmake --install <dir> --prefix command will cause a CMAKE_INSTALL_PREFIX to change, but not recompute things like CMAKE_INSTALL_LIBDIR.

This will cause any generated <project>-targets.cmake to be fundamentally broken as they will reference the CMAKE_INSTALL_PREFIX that was computed at configure time, and not the one at install time via the --prefix command.

While CCCL can be updated to better support absolute CMAKE_INSTALL_LIBDIR values, no promise can be made about correct/valid installations due to fundamental issue around using absolute values.

@jakirkham
Copy link
Member

As to CCCL-config.cmake, would it make sense to file an issue on RMM (or maybe also CCCL)?

@robertmaynard
Copy link
Contributor Author

As to CCCL-config.cmake, would it make sense to file an issue on RMM (or maybe also CCCL)?
CCCL issue has been opened:
NVIDIA/cccl#1390

@kkraus14 kkraus14 merged commit f49a1d9 into conda-forge:main Feb 15, 2024
8 checks passed
@jakirkham
Copy link
Member

Thanks Robert and Keith! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants