-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make calendar timezone, locale and dark mode aware #221
Conversation
✅ Deploy Preview for conda-dot-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Does it work in the main conda.org? |
Yes, it does! |
Seeing the same issue; the calendar is fine on the main conda.org site but in the deployment preview it's not connecting, as @kathatherine reported. |
I'm seeing the same connection issue at https://conda-forge.org/community/meetings/, which I know was recently updated. |
Does the iframe URL work for you? If it doesn't, do you see any errors? Maybe there's an error with the way the URL is being constructed dynamically in your clients. Can you right click on the errored iframe, click on "View Page Source" and report the Also, what does your browser console report for: Intl.DateTimeFormat().resolvedOptions().timeZone and new Intl.Locale(Intl.DateTimeFormat().resolvedOptions().locale).weekInfo.firstDay ? |
Ok I realized I can mock timezones in Chrome, and it had to do with Sunday being detected as the first day, which the previous logic identified as |
Woohoo! |
Looks good in the preview and live for me! |
Description
learn/
orcommunity/
, I have added it to the corresponding_sidebar.json
file.The new Google Calendar widget allows us to pass some locale parameters to make events easier to navigate.