Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make calendar timezone, locale and dark mode aware #221

Merged
merged 12 commits into from
Nov 7, 2024
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Nov 6, 2024

Description

  • If I have added a new page to learn/ or community/, I have added it to the corresponding _sidebar.json file.

The new Google Calendar widget allows us to pass some locale parameters to make events easier to navigate.

@jaimergp jaimergp requested review from a team as code owners November 6, 2024 13:59
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for conda-dot-org ready!

Name Link
🔨 Latest commit b4454de
🔍 Latest deploy log https://app.netlify.com/sites/conda-dot-org/deploys/672c8272724a22000889096d
😎 Deploy Preview https://deploy-preview-221--conda-dot-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kathatherine
Copy link
Contributor

kathatherine commented Nov 6, 2024

I don't know if this is an issue with the preview or with me, but Google Calendar isn't connecting for me in the preview (this is in Chrome).

image

@jaimergp
Copy link
Contributor Author

jaimergp commented Nov 6, 2024

I don't know if this is an issue with the preview or with me, but Google Calendar isn't connecting for me in the preview (this is in Chrome).

Does it work in the main conda.org?

@jaimergp jaimergp changed the title Make calendar timezone aware Make calendar timezone, locale and dark mode aware Nov 6, 2024
@kathatherine
Copy link
Contributor

I don't know if this is an issue with the preview or with me, but Google Calendar isn't connecting for me in the preview (this is in Chrome).

Does it work in the main conda.org?

Yes, it does!

@beeankha
Copy link
Member

beeankha commented Nov 6, 2024

Seeing the same issue; the calendar is fine on the main conda.org site but in the deployment preview it's not connecting, as @kathatherine reported.

@kathatherine
Copy link
Contributor

I'm seeing the same connection issue at https://conda-forge.org/community/meetings/, which I know was recently updated.

@jaimergp
Copy link
Contributor Author

jaimergp commented Nov 7, 2024

Does the iframe URL work for you? If it doesn't, do you see any errors?

Maybe there's an error with the way the URL is being constructed dynamically in your clients. Can you right click on the errored iframe, click on "View Page Source" and report the src field of the iframe tag?

Also, what does your browser console report for:

Intl.DateTimeFormat().resolvedOptions().timeZone

and

new Intl.Locale(Intl.DateTimeFormat().resolvedOptions().locale).weekInfo.firstDay

?

@jaimergp
Copy link
Contributor Author

jaimergp commented Nov 7, 2024

Ok I realized I can mock timezones in Chrome, and it had to do with Sunday being detected as the first day, which the previous logic identified as 8, which made the embed error in 400, which resulted in a redirect to an error page with headers that prevent the iframe from loading. Fun stuff. Should work now I think?

@jaimergp jaimergp merged commit e524256 into main Nov 7, 2024
6 checks passed
@jaimergp jaimergp deleted the timezone-aware branch November 7, 2024 09:06
@jezdez
Copy link
Member

jezdez commented Nov 7, 2024

Woohoo!

@kathatherine
Copy link
Contributor

Looks good in the preview and live for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants