-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xdg-mime
default registration
#227
Conversation
@mrclary could you check if this PR fixes your Linux issues? Thanks! |
@jaimergp, sorry for the late follow up. I've been sick all last week.
|
Perfect! I'm reading this as "it works as long as |
Okay, I'm a bit embarrassed. I was not aware of the |
I did find a couple bugs and polished the cleanup, so no worries, it was indeed useful! Glad you made it work too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think that this is PR is very useful: the documentation is clearer now and a subprocess call was replaced with a simple parser using only the standard library. To me, that's a win.
Just one small comment.
Description
Closes #226. Instead of using
xdg-mime default
, we editmimeapps.list
manually. If an application is already registered as default, we won't override it. We always populate the "Added associations" list with our desktop file so it's there in the "open with" menu. We also handle cleanups now.Checklist - did you ...
news
directory (using the template) for the next release's release notes?