Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 from CI test matrix. #263

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

marcoesters
Copy link
Contributor

Description

hypothesis, which is installed to run tests, has dropped Python 3.8 support, which leads to test failures. Drop Python 3.8 from the test matrix and bump the MacOS minimum Python version to 3.9.

Additionally, run apt-get update before running apt-get install so that apt finds all required packages on Ubuntu.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 15, 2024
@marcoesters marcoesters marked this pull request as ready for review October 15, 2024 16:02
@marcoesters marcoesters requested a review from a team as a code owner October 15, 2024 16:02
@jaimergp
Copy link
Contributor

Do we need to update the Python requirements in pyproject.toml and the conda recipe? This is a dependency of conda, and conda-libmamba-solver has already dropped 3.8 in the upcoming v2 compatibility PR, so it's a matter of time anyway...

@jaimergp
Copy link
Contributor

xref conda/conda#14201, for context.

@jaimergp jaimergp mentioned this pull request Oct 15, 2024
2 tasks
@marcoesters
Copy link
Contributor Author

Do we need to update the Python requirements in pyproject.toml and the conda recipe?

Not immediately because the code is still Python 3.8 compatible. I would follow the guidance in the cross-referenced issue. Since it is a dependency of conda, we shouldn't be dropping support before they do.

@jaimergp
Copy link
Contributor

Note we won't be able to provide 3.8 packages in conda-forge for the next release because it was dropped from the CI matrix.

@marcoesters
Copy link
Contributor Author

Note we won't be able to provide 3.8 packages in conda-forge for the next release because it was dropped from the CI matrix.

I think those are separate, albeit related, concerns and beyond the scope of this PR. It looks like the ecosystem as a whole need to come up with a deprecation policy.

Copy link
Contributor

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 for merge

@larsoner
Copy link
Contributor

... in the meantime this fixes broken CIs which is helpful so I'll merge, even if we might want to do more in follow-ups regarding properly dropping in pyproject.toml and elsewhere. Thanks @marcoesters !

@larsoner larsoner merged commit 9ec72f0 into conda:main Oct 17, 2024
17 checks passed
@jaimergp
Copy link
Contributor

Thank you @larsoner for pushing this. Just for context (in this case it was ok to merge), we have been usually leaving the final merge decision to the PR author when they are a contributor already. So for the future I think it's fair to "approve and wait", and if there's something blocked by the PR itself, kindly point it out for awareness.

@marcoesters marcoesters deleted the update-min-python-tests branch October 17, 2024 16:35
@marcoesters
Copy link
Contributor Author

And since @jaimergp had questions/objections, I would have waited for his approval here. I generally want to make sure that they are all addressed.

However since he said it was okay to merge, all is well that ends well.

@larsoner
Copy link
Contributor

Okay makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants