-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.8 from CI test matrix. #263
Conversation
Do we need to update the Python requirements in pyproject.toml and the conda recipe? This is a dependency of conda, and conda-libmamba-solver has already dropped 3.8 in the upcoming v2 compatibility PR, so it's a matter of time anyway... |
xref conda/conda#14201, for context. |
Not immediately because the code is still Python 3.8 compatible. I would follow the guidance in the cross-referenced issue. Since it is a dependency of |
Note we won't be able to provide 3.8 packages in conda-forge for the next release because it was dropped from the CI matrix. |
I think those are separate, albeit related, concerns and beyond the scope of this PR. It looks like the ecosystem as a whole need to come up with a deprecation policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1 for merge
... in the meantime this fixes broken CIs which is helpful so I'll merge, even if we might want to do more in follow-ups regarding properly dropping in |
Thank you @larsoner for pushing this. Just for context (in this case it was ok to merge), we have been usually leaving the final merge decision to the PR author when they are a contributor already. So for the future I think it's fair to "approve and wait", and if there's something blocked by the PR itself, kindly point it out for awareness. |
And since @jaimergp had questions/objections, I would have waited for his approval here. I generally want to make sure that they are all addressed. However since he said it was okay to merge, all is well that ends well. |
Okay makes sense 👍 |
Description
hypothesis
, which is installed to run tests, has dropped Python 3.8 support, which leads to test failures. Drop Python 3.8 from the test matrix and bump the MacOS minimum Python version to 3.9.Additionally, run
apt-get update
before runningapt-get install
so thatapt
finds all required packages on Ubuntu.Checklist - did you ...
news
directory (using the template) for the next release's release notes?