feat: add reinstallation method to installer and transaction #1128
+124
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
approved these changes
Feb 28, 2025
baszalmstra
reviewed
Feb 28, 2025
| @@ -50,6 +51,7 @@ pub struct Installer { | |||
| target_platform: Option<Platform>, | |||
| apple_code_sign_behavior: AppleCodeSignBehavior, | |||
| alternative_target_prefix: Option<PathBuf>, | |||
| reinstall_packages: Option<Vec<PackageName>>, | |||
There was a problem hiding this comment.
Maybe this should be a hashset set we only test for inclusion.
There was a problem hiding this comment.
Do you want to pass around the HashSet? If so we should get rid of the iterator as well in the Transaction I think :)
There was a problem hiding this comment.
Ok I've changed it to accept and pass HashSet's around :)
baszalmstra
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a re-installation method to the installer so that we can "force" reinstall packages which is something we want to do in pixi.
I've only added a method for testing the transaction, not sure if this is the right way to go about it :)