misc: simplify code and change warning to debug #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
approved these changes
Oct 4, 2023
|
Hmm, ideally I think we would show it as a warning once because we end up storing the passwords in clear text which is not great. |
|
@wolfv How would you approach that for this function? We could do a check on generation of the AuthenticationStorage ? |
|
Agreed, it should be a warning when storing the token, not when retrieving it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #363
This reduces the way the message used to scream at you, while it is totally normal to not have a keyring on your system.
Still not the best as it might be better to give this warning only once but this should help.