Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package cache lock file_name was incorrect #977

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

baszalmstra
Copy link
Collaborator

This PR fixes an issue where the package cache would be repopulated even though this was not required. This was because the individual cache entries shared the same lock file. For example these packages would all use the same lock file name (cffi-1.17.lock):

cffi-1.17.0-py38h4cb3324_0
cffi-1.17.1-py311he736701_0
cffi-1.17.1-py312h4389bb4_0
cffi-1.17.1-py313ha7868ed_0

This PR fixes this by correctly computing the lock file name for each entry (e.g. cffi-1.17.1-py313ha7868ed_0.lock).

Copy link
Collaborator

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy that it was so simple, nice find!

@baszalmstra baszalmstra merged commit eda953d into conda:main Dec 12, 2024
14 of 15 checks passed
@baszalmstra baszalmstra deleted the fix/cache_lock_filename branch December 12, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants