ibmcloud: PeerPod demo instructions for OpenShift clusters #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankbu
commented
Dec 4, 2024
bpradipt
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Apart from the comments I left I think there are minor improvement about having a more consistent base directory (it might just be me assuming things but I seemed to have to skip between the root project directory and src/cloud-api-adaptor a few times. But overall it looks great and I was able to get peer pods running on ROKS after your assistance. Once the comments are incorporated I will re-review and approve. Thanks @frankbu!
|
|
||
| ```bash | ||
| kubectl get pods -n default | ||
| kubectl get peerpod -n default |
There was a problem hiding this comment.
Sorry, it's probably embarrassing user error, but there isn't a type peerpod:
kubectl get peerpod -n default
error: the server doesn't have a resource type "peerpod"
There was a problem hiding this comment.
Hmm, I think the operator adds the CRD for peerpod. It works for me:
$ kubectl get peerpod -n default
NAME AGE
helloworld-resource-qtlr4 44h
stevenhorsman
approved these changes
Dec 5, 2024
Added doc with streamlined instructions to set up the peer pod demo environment using an OpenShift cluster. Also added references and made small corrections to the README. Signed-off-by: Frank Budinsky <[email protected]>
Remove unneeded advertise the extended resource step from README. Signed-off-by: Frank Budinsky <[email protected]>
stevenhorsman
force-pushed
the
peerpod-roks
branch
from
cc31873 to
ce2e294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added doc with streamlined instructions to set up the peer pod demo environment using an OpenShift cluster.
Also added references and made small corrections to the README.