Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource-uri: make repository part of resource path mandatory in docs #933

Conversation

pmores
Copy link
Contributor

@pmores pmores commented Feb 27, 2025

This is to align KBS URI documentation with trustee PR #720(*) which makes the repository part of resource path mandatory. Note that no code change seems necessary here since the actual 'ResourceUri' implementation has in fact already treated the repository part as mandatory, bailing out if it was missing.

(*) confidential-containers/trustee#720

This is to align KBS URI documentation with trustee PR confidential-containers#720(*) which makes
the repository part of resource path mandatory.  Note that no code change
seems necessary here since the actual 'ResourceUri' implementation has in
fact already treated the repository part as mandatory, bailing out if it
was missing.

(*) confidential-containers/trustee#720

Signed-off-by: Pavel Mores <[email protected]>
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm. Thanks!

@fitzthum fitzthum merged commit 18cce30 into confidential-containers:main Feb 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants