Upgrade min go 1.22 with tools #163
Merged
+133
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades the min go to v1.22 and tools buf and golangci-lint, fixing lint issues found. Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
emcfarlane
force-pushed
the
ed/upgradeTools
branch
from
6248332 to
1a44511
Compare
jhump
approved these changes
Mar 14, 2025
protocol_grpc.go
Outdated
| return nil | ||
| } | ||
| code := uint32(code64) |
There was a problem hiding this comment.
Why introduce new variable and rename previous one? Seems like you could just stick with code above and elide this.
If this is to avoid a "nolint" for the type conversion on line 536, I think it'd be better with the nolint comment TBH.
Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
emcfarlane
force-pushed
the
ed/upgradeTools
branch
from
9ec6b02 to
830cee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the min go to v1.22 and tools buf and golangci-lint, fixing lint issues found.