Fix code generation for interfaces inheriting from other interfaces #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @HugoX104447, thanks so much for the PR! I should have some time to take a look at it tomorrow. I can see that you added some tests so that should help me out a lot. |
- Update the code generator to properly recognize and process inherited interfaces. - Add unit test to validate the changes.
HugoX104447
force-pushed
the
fix-interface-inheritance
branch
from
5d682b6 to
637dc32
Compare
connorivy
added a commit
that referenced
this pull request
Jan 23, 2025
* Fix code generation for methods with default arguments * Fix code generation for interfaces inheriting from other interfaces (#36) - Update the code generator to properly recognize and process inherited interfaces. - Add unit test to validate the changes. * use unified interface and run formatter * Fix code generation for methods with default arguments (#35) * move default argument tests to shared project * Fix code generation for interfaces with overloaded methods (#38) * Fix code generation for interfaces inheriting from other interfaces - Update the code generator to properly recognize and process inherited interfaces. - Add unit test to validate the changes. * Fix code generation for interfaces with overloaded methods --------- Co-authored-by: Karsten Heimrich <[email protected]> Co-authored-by: Karsten Heimrich <[email protected]>
|
Hey @HugoX104447, I merged this in and it's part of 1.1.0. Let me know if you have any issues with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request addresses an issue in the code generation process for interfaces that inherit from other interfaces. The current implementation does not generate the code for the inherited interfaces.
Changes Made