Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of issue creation #44

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add an example of issue creation #44

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4456ee7
Add an example of issue creation
May 18, 2015
dac3bfb
Curl Driver: Make sure the SAFE_UPLOAD is set to false (since PHP 5.6…
Jun 11, 2015
a467755
Update README.md
t-keller Jun 11, 2015
9ada1b2
Delete useless file
Jun 11, 2015
64bacdd
Merge branch 'master' of https://github.com/t-keller/jira-api-restclient
Jun 11, 2015
58a5320
Revert "Delete useless file"
Jun 11, 2015
643c6f2
Update the composer.json
Jun 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Curl Driver: Make sure the SAFE_UPLOAD is set to false (since PHP 5.6… 
… the default value is TRUE)
  • Loading branch information
Thomas Keller committed Jun 11, 2015
commit dac3bfbe4260dc11dbb896a05d949384dc76a4e2
1 change: 1 addition & 0 deletions src/Jira/Api/Client/CurlClient.php
View file
Original file line number Diff line number Diff line change
@@ -78,6 +78,7 @@ public function sendRequest($method, $url, $data = array(), $endpoint, Authentic
if ($method == "POST") {
curl_setopt($curl, CURLOPT_POST, 1);
if ($isFile) {
curl_setopt($curl, CURLOPT_SAFE_UPLOAD, false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would result in an error prior PHP 5.5, where this option was added. Please remove from this PR.

This was fixed in #52 .

curl_setopt($curl, CURLOPT_POSTFIELDS, $data);
} else {
curl_setopt($curl, CURLOPT_POSTFIELDS, json_encode($data));