Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption. Change Mcrypt to OpenSSL #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ebogdanov
Copy link

There are plenty of things to discuss.

  1. OpenSSL can't decrypt RIJANDAEL-256 from Mcrypt. So that there should be some workaround to decrypt existing data with old cipher and encode with new one.
  2. I can't test Federated app right now.
  3. I do not like idea that I DB fields length should be increased.
  4. May be it's time to add use aes-256-cbc and add hash check also?

@febinthomas
Copy link

@ebogdanov Any progress on this..?

@devisgeorge
Copy link

@ebogdanov we were using the earlier version of the package for the past 2 years and was planning on a update of php 7.1 . The mentioned issue occurred in the package. Could you please update the latest version with the above fixes.

@ebogdanov
Copy link
Author

@febinthomas PR was ready for review&merge :) That's all I know.
@devisgeorge OK, but on weekend only. I've plenty of work these days.

@devisgeorge
Copy link

@ebogdanov Alright np .Thank you for the quick response.

@ebogdanov ebogdanov force-pushed the encryption/mcrypt-to-openssl branch 2 times, most recently from d63d70e to 5a9cedf Compare August 9, 2019 02:41
@ebogdanov
Copy link
Author

@devisgeorge OK, I've rebased this PR on the current head.

@febinthomas
Copy link

febinthomas commented Dec 27, 2019

@ebogdanov Could you please update the latest version with the above fixes.
@consolibyte could you please take a look on this

@ebogdanov
Copy link
Author

@febinthomas
Done. But PR shows some maddness with original commits. I do not have idea how to exclude those wasn't made by me.

@febinthomas
Copy link

febinthomas commented Dec 31, 2019

@ebogdanov create a new branch from master and try to squash merge your changes from current branch. then you can either create a new PR or force push to this PR

@ebogdanov ebogdanov force-pushed the encryption/mcrypt-to-openssl branch 2 times, most recently from db66c3f to f195fb3 Compare January 27, 2020 23:33
@ebogdanov ebogdanov force-pushed the encryption/mcrypt-to-openssl branch from f195fb3 to 273d679 Compare January 30, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants