Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Minify: Skip files without minifier & replace faulty message (Backport to 2.x) #1058

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

Image Minify: Skip files without minifier & replace faulty message (Backport to 2.x) #1058

wants to merge 3 commits into from

Commits on Nov 10, 2021

  1. [FEATURE] Image Minify: Add test for errors

    @pixelbrackets
    pixelbrackets committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    b6837c0 View commit details
    Browse the repository at this point in the history

  2. [BUGFIX] Image Minify: Replace missing error message placeholders 

    In case of an error the message contains placeholders which
are not replaced anymore downstream
(`Minified {filecount} out of {filetotal} images into {destination}`).
Print the result message as info and then return a short task message
without placeholders instead.
    @pixelbrackets
    pixelbrackets committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    fe061fc View commit details
    Browse the repository at this point in the history

  3. [BUGFIX] Image Minify: Skip files without minifier 

    Early return for all files which have no minifier set,
to avoid fatal error with ambigous error message
“Minifier method  cannot be found!”.
For example when webp images exist in the image directory.
The files are added to the error list right away,
to that the task may continue to minify other images and
show a result message (“Minified X of Y files”) at the end.
    @pixelbrackets
    pixelbrackets committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    c857919 View commit details
    Browse the repository at this point in the history