Skip to content

Deprecates volume plugin’s ability to declare offline/online expansion capability #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Deprecates volume plugin’s ability to declare offline/online expansion capability #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b1c7a3
Support online and offline expansion without requiring them to be dec…
gnufied May 7, 2020
226ec73
Mark VolumeExpansion capability in PluginCapability deprecated
gnufied May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion csi.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,10 @@ message PluginCapability {
Type type = 1;
}

// Deprecated - Ability for a plugin to delcare online and offline
// controller expansion capabilities via PluginCapability
// is deprecated. A plugin may support either mode of operation
// without having to declare them in PluginCapability.
message VolumeExpansion {
enum Type {
UNKNOWN = 0;
Expand Down Expand Up @@ -234,7 +238,18 @@ message PluginCapability {
oneof type {
// Service that the plugin supports.
Service service = 1;
VolumeExpansion volume_expansion = 2;
// Deprecated - Ability for a plugin to delcare online and offline
// controller expansion capabilities via PluginCapability
// is deprecated. A plugin may support either mode of operation
// without having to declare them in PluginCapability.
//
// If set a CO will ignore ONLINE and OFFLINE capabilities
// specified in PluginCapability.
// If a plugin can not support controller expansion of published
// and available volumes on a node - it may return
// FAILED_PRECONDITION error and CO should ensure that volume
// is not published before retrying with exponential backoff.
VolumeExpansion volume_expansion = 2 [deprecated=true];
}
}
message ProbeRequest {
Expand Down
Loading