Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODE-OF-CONDUCT.md to include Ramalama #2309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

caradelia
Copy link

@caradelia caradelia commented Jan 30, 2025

Signed-off-by: Cara Delia [email protected]

Signed-off-by: Cara Delia  <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caradelia
Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caradelia caradelia closed this Jan 30, 2025
@caradelia caradelia reopened this Jan 30, 2025
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title and commit do not match, what is the goal of listing this?

@@ -18,6 +18,7 @@ This documented is primarily aimed at the following repositories:
- [storage](https://github.com/containers/storage)
- [libhvee](https://github.com/containers/libhvee)
- [psgo](https://github.com/containers/psgo)
- [ramalama](https://github.com/containers/ramalama)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this added here? The reason I only listed these repos here are because they are go repos controlled by the podman team and this document contains golang specific information around how we do dependency updates there.
As such I don't think adding this here is appropriate. Looks like you already have all the importan info copied anyway: https://github.com/containers/ramalama/blob/main/CONTRIBUTING.md so I don't see what this is adding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants