Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] options/network: fix markdown lists #22372

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[CI:DOCS] options/network: fix markdown lists #22372

merged 1 commit into from
Apr 16, 2024

Conversation

baltitenger
Copy link
Contributor

Does this PR introduce a user-facing change?

None

@martinpitt martinpitt mentioned this pull request Apr 15, 2024
Merged
Luap99
Luap99 reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe what you are actually "fixing"?

docs/source/markdown/options/network.md Show resolved Hide resolved
docs/source/markdown/options/network.md Outdated Show resolved Hide resolved
@baltitenger
Copy link
Contributor Author

I updated the commit message and also changed parts of options to italic so it's clearer what part of them needs to be changed and what's typed verbatim as per man(1).

Btw the [CI:DOCS] prefix doesn't seem to do its thing, it runs all the tests anyway.

@baude
Copy link
Member

baude commented Apr 15, 2024

Btw the [CI:DOCS] prefix doesn't seem to do its thing, it runs all the tests anyway.

It most certainly did not ...

@baude
Copy link
Member

baude commented Apr 15, 2024

small NIT, LGTM otherwise.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@baltitenger
[CI:DOCS] options/network: fix markdown lists
d4ecae5 
Markdown needs lists to be separate paragraphs, otherwise all the items
end up in a single line.

I also made arguments to be replaced italic to clarify that they
shouldn't be typed exactly as shown.

Signed-off-by: Baltazár Radics <[email protected]>
Luap99
Luap99 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baltitenger, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f3276e7 into containers:main Apr 16, 2024
40 of 42 checks passed
@Luap99 Luap99 mentioned this pull request Apr 27, 2024
Open
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 16, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baude baude baude left review comments

@Luap99 Luap99 Luap99 approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baltitenger @baude @Luap99