Skip to content

Commit 0ea9260

Browse files
authoredSep 8, 2022
fix: notification (#2207)
* fix: notification * chore: changelog * fix: fix props and remove redundent d.ts

File tree

5 files changed

+15
-17
lines changed

5 files changed

+15
-17
lines changed
 

‎.changeset/unlucky-queens-think.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@contentful/f36-notification': minor
3+
---
4+
5+
Upgrade react-animate-height to fix f36-notification

‎packages/components/notification/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"@contentful/f36-typography": "^4.18.0",
1616
"@swc/helpers": "^0.4.2",
1717
"emotion": "^10.0.17",
18-
"react-animate-height": "^2.0.23"
18+
"react-animate-height": "^3.0.4"
1919
},
2020
"peerDependencies": {
2121
"react": ">=16.8",

‎packages/components/notification/src/NotificationItem/NotificationItemContainer.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export class NotificationItemContainer extends Component<
8787
height={this.state.isShown ? 'auto' : 0}
8888
easing="ease-in-out"
8989
animateOpacity
90-
onAnimationEnd={() => {
90+
onHeightAnimationEnd={() => {
9191
if (this.state.isShown === false) {
9292
if (this.props.onClose) {
9393
this.props.onClose();

‎types/typings.d.ts

-6
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,6 @@ declare module '*.md' {
99
export default value;
1010
}
1111

12-
declare module 'react-animate-height' {
13-
// eslint-disable-next-line
14-
const value: any;
15-
export default value;
16-
}
17-
1812
declare module '@storybook/addon-actions' {
1913
export const action: any;
2014
}

‎yarn.lock

+8-9
Original file line numberDiff line numberDiff line change
@@ -7185,9 +7185,9 @@ class-utils@^0.3.5:
71857185
isobject "^3.0.0"
71867186
static-extend "^0.1.1"
71877187

7188-
classnames@^2.2.5:
7188+
classnames@^2.3.1:
71897189
version "2.3.1"
7190-
resolved "https://registry.npmjs.org/classnames/-/classnames-2.3.1.tgz"
7190+
resolved "https://registry.yarnpkg.com/classnames/-/classnames-2.3.1.tgz#dfcfa3891e306ec1dad105d0e88f4417b8535e8e"
71917191
integrity sha512-OlQdbZ7gLfGarSqxesMesDa5uz7KFbID8Kpq/SxIoNGDqY8lSYs0D+hhtBXhcdB3rcbXArFr7vlHheLk1voeNA==
71927192

71937193
clean-css@^4.2.3:
@@ -18057,7 +18057,7 @@ promzard@^0.3.0:
1805718057
dependencies:
1805818058
read "1"
1805918059

18060-
prop-types@^15.0.0, prop-types@^15.5.7, prop-types@^15.6.1, prop-types@^15.6.2, prop-types@^15.7.2, prop-types@^15.8.1:
18060+
prop-types@^15.0.0, prop-types@^15.5.7, prop-types@^15.6.2, prop-types@^15.7.2, prop-types@^15.8.1:
1806118061
version "15.8.1"
1806218062
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.8.1.tgz#67d87bf1a694f48435cf332c24af10214a3140b5"
1806318063
integrity sha512-oj87CgZICdulUohogVAR7AjlC0327U4el4L6eAvOqCeudMDVU0NThNaV+b9Df4dXgSP1gXMTnPdhfe/2qDH5cg==
@@ -18293,13 +18293,12 @@ rc@^1.0.1, rc@^1.1.6, rc@^1.2.7, rc@^1.2.8:
1829318293
minimist "^1.2.0"
1829418294
strip-json-comments "~2.0.1"
1829518295

18296-
react-animate-height@^2.0.23:
18297-
version "2.0.23"
18298-
resolved "https://registry.npmjs.org/react-animate-height/-/react-animate-height-2.0.23.tgz"
18299-
integrity sha512-DucSC/1QuxWEFzR9IsHMzrf2nrcZ6qAmLIFoENa2kLK7h72XybcMA9o073z7aHccFzdMEW0/fhAdnQG7a4rDow==
18296+
react-animate-height@^3.0.4:
18297+
version "3.0.4"
18298+
resolved "https://registry.yarnpkg.com/react-animate-height/-/react-animate-height-3.0.4.tgz#80c9cc25e8569709ad1c626b968dbe5108d0ce46"
18299+
integrity sha512-k+mBS8yCzpFp+7BdrHsL5bXd6CO/2bYO2SvRGKfxK+Ss3nzplAJLlgnd6Zhcxe/avdpy/CgcziicFj7pIHgG5g==
1830018300
dependencies:
18301-
classnames "^2.2.5"
18302-
prop-types "^15.6.1"
18301+
classnames "^2.3.1"
1830318302

1830418303
react-clientside-effect@^1.2.6:
1830518304
version "1.2.6"

1 commit comments

Comments
 (1)

vercel[bot] commented on Sep 8, 2022

@vercel[bot]
Please sign in to comment.