Skip to content

Enhance SyncStack to handle ArrayList #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

reeshika-h
Copy link
Contributor

  • Improved error logging for 'items' processing
  • Added test for real API call to syncContentType

…items' processing

Added test for real API call to syncContentType.
@reeshika-h reeshika-h requested a review from harshithad0703 June 4, 2025 10:56
@aman19K aman19K requested a review from Copilot June 4, 2025 10:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the SyncStack module by allowing the processing of items provided as ArrayLists and improves error logging while adding a new integration test for syncContentType real API calls.

  • Added ArrayList support for 'items' processing in SyncStack.
  • Improved error logging messages for invalid 'items' types.
  • Introduced a real API call test for syncContentType with asynchronous handling.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/test/java/com/contentstack/sdk/TestSyncStack.java Added testRealSyncContentType method to validate actual API responses.
src/main/java/com/contentstack/sdk/SyncStack.java Handled ArrayList in items processing with additional logging.

nadeem-cs
nadeem-cs previously approved these changes Jun 4, 2025
…ancing flexibility in handling various collection types.
Copy link

@AniketDev7 AniketDev7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reeshika-h reeshika-h marked this pull request as ready for review June 5, 2025 07:11
@reeshika-h reeshika-h requested a review from a team as a code owner June 5, 2025 07:11
@reeshika-h reeshika-h merged commit 043e2c7 into development Jun 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants