Corrections to Boston fare router #655
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… point-to-point router server is internal
…ules for all from leg groups
…ns traversed, not from and to station
Co-authored-by: Anson Stewart <[email protected]>
…g bitset comparison with int comparison. Previously we compared whether a leg had a superset of the potentially-active fare transfer rules of another leg, but because most fare_transfer_rules specify a from_leg_group_id, the superset would only be active in a few cases: 1) when there are transfer rules with no from_leg_group_id 2) when two trips have the same price but one has no transfer allowance 3) when the two trips have the same previous leg group 99% of the time (not measured), it was the third condition that eliminated legs. We can implement the third condition with a simple integer equality, rather than a BitSet operation. The others are rare enough that ignoring them makes us retain maybe a few more trips, but not enough to outweight the performance penalty of a big BitSet comparison.
…sfer from a bus, fixes conveyal#588.
…yal#593) and use boston-specific logic in dominance (addresses conveyal#595)
…n called in superclass, adresses conveyal#595.
…they show in Fareto
…enExpiration called unsafely.
… rail." This reverts commit db439cf0ebe9725d3d01dc72cdedc369d489f85d. Allowing free transfers on commuter rail violates nonnegativity of transfer allowances.
…y after riding the silver line for free
…behind-gates transfer
…ort when original boarding was SL_FREE
…aying fare or for free
mattwigway
force-pushed
the
boston-fare-corrections
branch
from
e4fa4fd
to
5e8a656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons, this also includes the FaresV2 branch. We could strip these apart if need be, but it's a bit tricky.