add set_room_override #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isaac0-dev
reviewed
Nov 25, 2024
src/game/object_helpers.c
Outdated
| gRoomOverride = room; | ||
| } | ||
|
|
||
| s16 get_room_at_pos(f32 x, f32 y, f32 z) { |
There was a problem hiding this comment.
this function seems to only be useful in very specific situations. it would probably be more useful if you could enable gFindFloorIncludeSurfaceIntangible for your own ray casts, since you can already just get the room parameter from the surface you find.
There was a problem hiding this comment.
can't raycasts already get intangible surface types?, i'll probably just remove this function
There was a problem hiding this comment.
having gFindFloorIncludeSurfaceIntangible true does change the behavior of find_floor but its fine if you just remove the function too.
Isaac0-dev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets you override the displayed room, do set_room_override(-1) in order to get back to normal
sm64coopdx.v1.0.4.2024-11-25.21-01-08.mp4