es6 #1281
Merged
es6 #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basicer
force-pushed
the
es6
branch
6 times, most recently
from
7709fe9 to
00c01fe
Compare
basicer
force-pushed
the
es6
branch
8 times, most recently
from
d0b3982 to
128208a
Compare
SuperMaxusa
reviewed
Mar 31, 2025
SuperMaxusa
reviewed
Mar 31, 2025
| @@ -92,7 +97,7 @@ else | |||
| LoadBinaryResource = function(url, OnSuccess, OnError) | |||
| { | |||
| //console.log(url); | |||
| require("fs")["readFile"](url, function(err, data) | |||
| import("node:" + "fs").then(fs => fs["readFile"](url, function(err, data) | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah, otherwise closure compalins it cant find the module. Making it an expression like this seems to suppress that.
|
Excellent stuff, thanks! |
|
@basicer: Many thanks for this! My v86 embedding was already module-based and switching over to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.