Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fixes #4

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Spelling fixes #4

wants to merge 17 commits into from

Conversation

jsoref
Copy link

@jsoref jsoref commented Jan 8, 2013

Yes, one or two of these changes may be to third party libraries, please feel free to submit those changes to them....

Using consistent and expected spelling in code, comments and documentation especially for Samples such as this helps everyone.

@girliemac
Copy link
Member

Thanks Josh,
I have changed a bunch of files at the same time you made the pull request, so to avoid fixing a bunch of conflicts, I am fixing the spelling errors manually!
And I do need your keen eyes when the app is finishing too.

@jsoref
Copy link
Author

jsoref commented Jan 23, 2013

Any decent DVCS should be able to handle this, since each spelling fix is a single commit, basically you just let the rebase drop each conflicting commit and then for the conflicts you look at what they were trying to do.

OTOH, because of the way the commits are structured, applying the changes manually may be just as easy, which is fine w/ me. I don't mind.

And when the application is ready, just ping me, I'm happy to give it a spin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants