Return drawable with on resource ready callback #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 4, 2021 20:08
…b.com:abhriyaroy/GlideToVectorYou into return-drawable_with-onResourceReady-callback
When using a listener, the drawable obtained in the callback can be used instead of supplying an imageview as an extra argument. This will cater to the cases, where the user only wants to load a PictureDrawable without setting it to any specific imageview.
SubhrajyotiSen
suggested changes
Mar 4, 2021
| @@ -50,7 +53,7 @@ public GlideToVectorYou setPlaceHolder(int placeHolderLoading, int placeHolderEr | |||
| return instance; | |||
| } | |||
|
|
|||
| public void load(Uri uri, ImageView imageView) { | |||
| public void load(Uri uri) { | |||
There was a problem hiding this comment.
This will break existing implementations. Maybe add a new method with the method signature that you want?
There was a problem hiding this comment.
Sure. Kept the older method and just added a new one.
| @@ -41,11 +41,9 @@ public boolean onLoadFailed(GlideException e, Object model, Target<PictureDrawab | |||
| @Override | |||
| public boolean onResourceReady(PictureDrawable resource, Object model, | |||
| Target<PictureDrawable> target, DataSource dataSource, boolean isFirstResource) { | |||
| ImageView view = ((ImageViewTarget<?>) target).getView(); | |||
There was a problem hiding this comment.
You might want to keep this as is for backward compatibility as well
There was a problem hiding this comment.
Yes. I didn't consider backward compatibility. Have modified the same.
| public interface GlideToVectorYouListener { | ||
| void onLoadFailed(); | ||
| void onResourceReady(); | ||
| void onResourceReady(PictureDrawable pictureDrawable); |
There was a problem hiding this comment.
Depending on whether the PictureDrawable can be null or not, an annotation here would be helpful. For Kotlin usages
- Add support for backward compaitibility by keeping previous method for normal loading - Add nullable annotation to onResourceReady
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning the drawable as a callback will allow the user to use the drawable as any manner which seems fit and not just bound to setting it to an Imageview.