Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value in vectorize when dataarray has no name, and a warning #166

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

Imanflow
Copy link
Contributor

@Imanflow Imanflow commented Mar 8, 2024

@snowman2 snowman2 added the enhancement New feature or request label Mar 9, 2024
@snowman2 snowman2 added this to the 0.5.0 milestone Mar 9, 2024
@snowman2
Copy link
Member

Running this should help address linting issues:

python -m pip install pre-commit
cd ./geocube
pre-commit install
pre-commit run -a

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (a69f63d) to head (c06e32b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   96.23%   96.28%   +0.04%     
==========================================
  Files          14       14              
  Lines         452      457       +5     
==========================================
+ Hits          435      440       +5     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snowman2 snowman2 merged commit 5fa79a4 into corteva:master Mar 18, 2024
16 checks passed
@snowman2
Copy link
Member

Thanks @Imanflow 👍

@snowman2 snowman2 modified the milestones: 0.5.0, 0.5.1 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a name for the value column in vectorize
3 participants