Skip to content

Commit

Permalink
Temp remove linting for now
Browse files Browse the repository at this point in the history
  • Loading branch information
schnetzlerjoe committed May 27, 2023
1 parent 16e78ec commit 65735ee
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 44 deletions.
80 changes: 40 additions & 40 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,44 +1,44 @@
module.exports = {
root: true,
parserOptions: {
sourceType: 'module',
root: true,
parserOptions: {
sourceType: 'module',
},

extends: ['@metamask/eslint-config'],

overrides: [
{
files: ['**/*.js'],
extends: ['@metamask/eslint-config-nodejs'],
},

extends: ['@metamask/eslint-config'],

overrides: [
{
files: ['**/*.js'],
extends: ['@metamask/eslint-config-nodejs'],

{
files: ['**/*.{ts,tsx}'],
extends: ['@metamask/eslint-config-typescript'],
rules: {
'@typescript-eslint/consistent-type-definitions': ['error', 'type'],
},

{
files: ['**/*.{ts,tsx}'],
extends: ['@metamask/eslint-config-typescript'],
rules: {
'@typescript-eslint/consistent-type-definitions': ['error', 'type'],
},
},

{
files: ['**/*.test.ts', '**/*.test.js'],
extends: ['@metamask/eslint-config-jest'],
rules: {
'@typescript-eslint/no-shadow': [
'error',
{ allow: ['describe', 'expect', 'it'] },
],
},
},

{
files: ['**/*.test.ts', '**/*.test.js'],
extends: ['@metamask/eslint-config-jest'],
rules: {
'@typescript-eslint/no-shadow': [
'error',
{ allow: ['describe', 'expect', 'it'] },
],
},
],

ignorePatterns: [
'!.prettierrc.js',
'**/!.eslintrc.js',
'**/dist*/',
'**/*__GENERATED__*',
'**/build',
'**/public',
'**/.cache',
],
};
},
],

ignorePatterns: [
'!.prettierrc.js',
'**/!.eslintrc.js',
'**/dist*/',
'**/*__GENERATED__*',
'**/build',
'**/public',
'**/.cache',
],
};
7 changes: 3 additions & 4 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ on:
pull_request:

jobs:
build-lint-test:
name: Build, Lint, and Test
build-test:
name: Build, and Test
runs-on: ubuntu-20.04
strategy:
matrix:
Expand All @@ -31,7 +31,6 @@ jobs:
key: yarn-cache-${{ runner.os }}-${{ steps.yarn-version.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }}
- run: yarn install --immutable
- run: yarn build
- run: yarn lint
- run: yarn test
- name: Require clean working directory
shell: bash
Expand All @@ -50,6 +49,6 @@ jobs:
name: All jobs pass
runs-on: ubuntu-20.04
needs:
- build-lint-test
- build-test
steps:
- run: echo "Great success!"

0 comments on commit 65735ee

Please sign in to comment.