Skip to content

adding-anywhere-footnote #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

RayOffiah
Copy link
Contributor

Adding support for footnotes that can appear anywhere on the page.

@RayOffiah RayOffiah self-assigned this Jun 29, 2025
@RayOffiah RayOffiah marked this pull request as ready for review July 2, 2025 13:01
@RayOffiah RayOffiah requested a review from osfameron July 2, 2025 13:01
Copy link
Collaborator

@osfameron osfameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to replace the UI bundle when that's merged in

@osfameron
Copy link
Collaborator

I think the steps to get this merged in are:

  1. PR in e.g. docs-server that makes use of it, along with a preview.
    Get the PR approved by one other person working on docs-server.

  2. docs-ui PR merged

  3. update this PR with new UI version number and then merge.

I think 1) is important because we don't want the complexity of extensions added just "on the off chance", but because they have a recognized benefit to the team.

@RayOffiah RayOffiah marked this pull request as draft July 2, 2025 14:40
@RayOffiah RayOffiah force-pushed the adding-anywhere-footnote branch 4 times, most recently from 5b44440 to 6fb9dc8 Compare July 7, 2025 08:14
The PR for the new UI bundle (couchbase/docs-ui#193) should be reviewed first so we know the number of the bundle.

Upgrade `asciidoctor-anywhere-footnote` to ~1.1.8 and update dependencies in `package-lock.json`.

Updating package.json

Adding the anywhere-footnote extension
@RayOffiah RayOffiah force-pushed the adding-anywhere-footnote branch from b171378 to 020bf30 Compare July 11, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants