Skip to content

Add NGINX redirect rules for erroneous API pages and test configuration #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RayOffiah
Copy link
Contributor

Added rules to trap and redirect the pages for API Enumerations and Structures.

@RayOffiah RayOffiah requested a review from osfameron July 2, 2025 12:57
@RayOffiah RayOffiah self-assigned this Jul 2, 2025
@RayOffiah RayOffiah added the enhancement New feature or request label Jul 2, 2025
Add NGINX redirect rules for erroneous API pages and test configuration

Introduced new redirect rules in NGINX snippets to address erroneous API pages and added a localized test configuration for debugging.
@RayOffiah RayOffiah force-pushed the fix-for-enumeration-structure-api-pages branch from a068118 to 5fa5c21 Compare July 4, 2025 10:01
@RayOffiah RayOffiah requested a review from osfameron July 4, 2025 10:02
Copy link
Collaborator

@osfameron osfameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem to work, e.g

Looking at our rewrites, we don't use ~* at all... I wonder if we could use the approach used elsewhere, something like:

location ^~ /mobile/ {
    rewrite ^/mobile/([^/]+)/(couchbase-lite-swift)/Enumerations.html$ /mobile/$1/$2/Enums.html redirect; 
    rewrite ^/mobile/([^/]+)/(couchbase-lite-swift)/Structures.html$ /mobile/$1/$2/Structs.html redirect; 
}

(Not tested 🙈)

@RayOffiah
Copy link
Contributor Author

Okay, changed it target the mobile section.

@RayOffiah
Copy link
Contributor Author

Works locally, but so did the last attempt.

@RayOffiah
Copy link
Contributor Author

It also suggested moving the section further up in the config so that it gets matched earlier on, but let's try this first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants