Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThejasNU/Fix index ignore files crawling issue #66

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

ThejasNU
Copy link
Collaborator

This PR fixes the issue where index command used to consider the .gitignore and .agentcingore present only the user provided directory.

Code has been modified to crawl from the root directory till user provided directory and find all .gitignore and .agentcingore files present in all directories in the path similar to how git searches for .gitingore files

@ThejasNU ThejasNU self-assigned this Jan 29, 2025
@ThejasNU ThejasNU requested review from glennga and TJ202 January 29, 2025 11:33
Copy link
Collaborator

@glennga glennga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test that codifies this behavior (you can create a unit test for this method specifically, don't need to go through the entire index workflow)

@ThejasNU ThejasNU requested a review from glennga February 3, 2025 05:58
Copy link
Collaborator

@glennga glennga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ThejasNU ThejasNU merged commit 28bcebf into master Feb 5, 2025
5 checks passed
@ThejasNU ThejasNU deleted the ThejasNU/ignore_files branch February 5, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants