Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(atomic): reset dependent numeric / date facet input when parent facet is cleared #4851

Merged
merged 19 commits into from
Jan 31, 2025
Merged

fix(atomic): reset dependent numeric / date facet input when parent facet is cleared #4851

merged 19 commits into from
Jan 31, 2025

Conversation

fbeaudoincoveo
Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo requested review from a team as code owners January 14, 2025 16:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243.9 243.9 0
commerce 355.2 355.2 0
search 415.1 415.1 0
insight 406.3 406.3 0
recommendation 256.2 256.2 0
ssr 409 409 0
ssr-commerce 373 373 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

louis-bompart
louis-bompart reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A playwright test might be good

@fbeaudoincoveo
Copy link
Contributor Author

A playwright test might be good

Done!

erocheleau
erocheleau approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I will create a jira to mention that we should also test that within Quantic that it respects the default behavior with dependent facets.

@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Jan 31, 2025
Merged via the queue into master with commit b30b8a2 Jan 31, 2025
96 checks passed
@fbeaudoincoveo fbeaudoincoveo deleted the KIT-3746 branch January 31, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpbrault fpbrault fpbrault approved these changes

@erocheleau erocheleau erocheleau approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@dmgauthier dmgauthier dmgauthier approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fbeaudoincoveo @fpbrault @erocheleau @louis-bompart @dmgauthier