Skip to content

Fix #24: markdown.css should be upstream #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix #24: markdown.css should be upstream #40

wants to merge 2 commits into from

Conversation

yvan-sraka
Copy link
Collaborator

No description provided.

@yvan-sraka yvan-sraka self-assigned this Jan 14, 2022
@yvan-sraka yvan-sraka linked an issue Jan 14, 2022 that may be closed by this pull request
@yvan-sraka yvan-sraka marked this pull request as draft January 14, 2022 16:08
font-feature-settings: "calt" 1; /* Enable ligatures for IE 10+, Edge */
text-rendering: optimizeLegibility; /* Force ligatures for Webkit, Blink, Gecko */
}
.rstrtt h1 { font-size: 3rem; }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder about having different font-size for different heading level?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the different sizes

overflow: hidden;
}
.rstrtt h1:after {
content: "====================================================================================================";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also find out that the line was a bit disturbing, so I wonder of removing it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you dont like it remove it :)

display: inline;
color: $light-grey;
}
.rstrtt h1:before {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and rather having a lighter heading rule for h1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the # before the h1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markdown.css should be upstream
2 participants