Python implementation using pybind11 and gobject introspection #181

zalox · 2016-04-04T08:10:09Z

No description provided.

zalox · 2016-04-04T08:11:40Z

Replaces #99

eidheim · 2016-04-09T07:38:38Z

src/python_interpreter.cc

+    std::cerr << std::string(err) << std::endl;
+}
+
+PythonError::PythonError(){


@zalox Have not studied the changes in detail, just saw that you repeated Python in for instance PythonInterpreter and PythonError. I think its better to use namespaces such that it becomes: Python::Interpreter and Python::Error.

zalox · 2016-04-19T07:56:04Z

Working plugins here for now: https://github.com/zalox/jucipp-plugins

zalox · 2016-04-19T11:33:35Z

@milleniumbug Did you manage to test the plugins?

milleniumbug · 2016-04-19T11:35:11Z

Not yet, I'm trying to. The missing Py_DecodeLocale was the immediate issue that prevented me from compiling this branch.

zalox · 2016-04-19T11:43:14Z

docs/install.md

@@ -143,7 +143,7 @@ Note that juCi++ must be run in a MinGW Shell (for instance MinGW-w64 Win64 Shel

 Install dependencies (replace `x86_64` with `i686` for 32-bit MSYS2 installs):
 ```sh
-pacman -S git mingw-w64-x86_64-cmake make mingw-w64-x86_64-toolchain mingw-w64-x86_64-clang mingw-w64-x86_64-gtkmm3 mingw-w64-x86_64-gtksourceviewmm3 mingw-w64-x86_64-boost mingw-w64-x86_64-aspell mingw-w64-x86_64-aspell-en
+pacman -S git mingw-w64-x86_64-cmake make mingw-w64-x86_64-toolchain mingw-w64-x86_64-clang mingw-w64-x86_64-gtkmm3 mingw-w64-x86_64-gtksourceviewmm3 mingw-w64-x86_64-boost mingw-w64-x86_64-aspell mingw-w64-x86_64-aspell-en mingw-w64-x86_64-gobject-introspection mingw-w64-x86_64-pygobject-devel mingw-w64-x86_64-python3-gobject
 ```


@milleniumbug You will probably need some variant of these packages as well. I needed to point to my site-packages on windows and debian. Arch was fine.

milleniumbug · 2016-04-19T13:02:42Z

Ok, after installing necessary dependencies, setting site-packages in config.json to correct path, snippet.py works correctly, but tools.py doesn't seem to load at all. (Python version: 3.4)

Dependencies for Fedora 23: gobject-introspection-devel pygobject3-devel python3-gobject (posting here so I won't forget)

zalox · 2016-04-19T13:13:51Z

Are there no errors in the terminal?

milleniumbug · 2016-04-19T13:15:00Z

None at all. I've verified that it doesn't load by putting some logging statements in tools.py (with jucipp.terminal.println("test"))

milleniumbug · 2016-04-19T13:18:30Z

Okay, nevermind. Moving snippet.py outside and renaming tools.py to snippet.py loads the plugin, so probably I have forgotten to put it on some list.

@milleniumbug

@milleniumbug See if this fixes it

zalox · 2016-04-19T13:41:44Z

@eidheim I'm having trouble persisting my config.json file. Is there any mechanism that overwrites the file or anything in it?

I had the issues in msys2.

eidheim · 2016-04-19T13:45:42Z

As long as you have the same version number in the config file, as in the files.h, juCi++ will not touch the config file. However, if the versions are different, changes will be done to the old config file so that it corresponds to the new file specified in files.h.

zalox · 2016-04-19T13:52:47Z

I had some very strange behaviour then. I'll try to reproduce when I get back to windows.

eidheim · 2016-04-19T13:58:50Z

Windows does some file lock if a file is opened by another process? That might have been the case, denying the write to you your config file. Although, I'm not very experienced with Windows.

milleniumbug · 2016-04-19T14:08:25Z

I've debugged the program, and it seems it stops searching for plugins on first hidden file.

/home/milleniumbug/.juci/plugins/snippet.py - full
snippet - stem
/home/milleniumbug/.juci/plugins/.gitignore - full
 - stem
/home/milleniumbug/.juci/plugins/__pycache__ - full
__pycache__ - stem
/home/milleniumbug/.juci/plugins/README.md - full
README - stem
/home/milleniumbug/.juci/plugins/LICENSE - full
LICENSE - stem
/home/milleniumbug/.juci/plugins/tools.py - full
tools - stem
/home/milleniumbug/.juci/plugins/.git - full
 - stem

Changing from

    auto module_name=it->path().stem().string();
    if(module_name.empty())
      break;

to

    auto module_name=it->path().stem().string();
    if(module_name.empty())
      continue;

fixed the problem.

zalox · 2016-04-19T14:24:14Z

src/python_interpreter.cc

@@ -95,7 +95,7 @@ Python::Interpreter::Interpreter(){
  for(boost::filesystem::directory_iterator it(plugin_path);it!=end_it;it++){
    auto module_name=it->path().stem().string();
    if(module_name.empty())
-      break;
+      continue;
    auto is_directory=boost::filesystem::is_directory(it->path());


@milleniumbug I fixed it this morning. You probably pulled before.

zalox · 2016-04-19T23:14:00Z

It might be possible to do it inClangViewAutocomplete::autocomplete_get_suggestions by asking i.e.Python::Interpreter::get_suggestions. The suggestions can be dynamically produced by clang context in plugins. If the interpreter and clang works in parallel I think it might work without a huge performance drop.

This approach isn't very generic and re-factoring might be needed for a reasonable solution.

eidheim · 2016-04-20T06:18:20Z

@zalox I've been thinking about simpler ways to reuse the autocompletion dialog. I'll prioritize this in the coming weeks.

zalox · 2016-05-26T13:38:17Z

I updated the docker images with python now. I only updated the packages, so it shouldn't break other builds. https://hub.docker.com/r/cppit/jucipp/builds/

eidheim · 2016-05-26T13:40:03Z

Coincidently, I'll test it on master now:)

zalox · 2016-05-26T13:45:41Z

cppit/jucipp-docker@9cb5f6e

zalox self-assigned this Apr 4, 2016

zalox added enhancement plugin labels Apr 4, 2016

zalox added this to the v.1.3 milestone Apr 4, 2016

zalox force-pushed the python-refactor branch 4 times, most recently from d82ae2b to 9bdc0c9 Compare April 8, 2016 12:49

eidheim reviewed Apr 9, 2016
View reviewed changes

zalox force-pushed the python-refactor branch 2 times, most recently from 94c68fd to 3513d4f Compare April 9, 2016 16:32

zalox force-pushed the python-refactor branch 2 times, most recently from 97504ef to 989501f Compare April 18, 2016 16:08

zalox force-pushed the python-refactor branch from 4645fe9 to 5c2a322 Compare April 19, 2016 11:42

zalox reviewed Apr 19, 2016
View reviewed changes

zalox referenced this pull request in zalox/jucipp-plugins Apr 19, 2016

Change to gio application

a30ab53

@milleniumbug See if this fixes it

zalox reviewed Apr 19, 2016
View reviewed changes

zalox force-pushed the master branch 2 times, most recently from e10188b to 6dac0b7 Compare May 5, 2016 12:10

zalox force-pushed the python-refactor branch from 08c95ce to 4896322 Compare May 26, 2016 13:04

zalox force-pushed the python-refactor branch from 6d5f303 to 3ce5015 Compare June 12, 2016 19:00

zalox force-pushed the python-refactor branch 6 times, most recently from 15b91fd to b019550 Compare September 4, 2016 14:30

zalox force-pushed the python-refactor branch from c4307cf to 873090d Compare December 13, 2016 22:30

zalox force-pushed the python-refactor branch 3 times, most recently from 73502bd to b285d3d Compare February 18, 2017 15:02

zalox force-pushed the python-refactor branch 3 times, most recently from 1e57586 to bb6b4aa Compare February 28, 2017 22:50

eidheim and others added 5 commits June 10, 2018 15:48

Updated tiny-process-library submodule that has moved to GitLab

dc4e752

feature: add pybind11 submodule

641120f

feature: new plugin implementation for python

3dcb935

Backported Py_DecodeLocale from 3.5

301bd0b

feature: Update pybind11 to latest version

8d84ac5

zalox force-pushed the python-refactor branch from bb6b4aa to 8d84ac5 Compare June 10, 2018 18:17

zalox removed this from the v.1.3 milestone Jun 10, 2018

eidheim force-pushed the master branch from dc4e752 to 10b0a3c Compare June 11, 2018 10:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python implementation using pybind11 and gobject introspection #181

Python implementation using pybind11 and gobject introspection #181

zalox commented Apr 4, 2016 •

edited

Loading

zalox commented Apr 4, 2016

eidheim Apr 9, 2016

zalox commented Apr 19, 2016

zalox commented Apr 19, 2016

milleniumbug commented Apr 19, 2016

zalox Apr 19, 2016

milleniumbug commented Apr 19, 2016 •

edited

Loading

zalox commented Apr 19, 2016

milleniumbug commented Apr 19, 2016

milleniumbug commented Apr 19, 2016

zalox commented Apr 19, 2016

eidheim commented Apr 19, 2016 •

edited

Loading

zalox commented Apr 19, 2016 •

edited

Loading

eidheim commented Apr 19, 2016

milleniumbug commented Apr 19, 2016 •

edited

Loading

zalox Apr 19, 2016

zalox commented Apr 19, 2016

eidheim commented Apr 20, 2016 •

edited

Loading

zalox commented May 26, 2016

eidheim commented May 26, 2016

zalox commented May 26, 2016

Python implementation using pybind11 and gobject introspection #181

Are you sure you want to change the base?

Python implementation using pybind11 and gobject introspection #181

Conversation

zalox commented Apr 4, 2016 • edited Loading

zalox commented Apr 4, 2016

eidheim Apr 9, 2016

Choose a reason for hiding this comment

zalox commented Apr 19, 2016

zalox commented Apr 19, 2016

milleniumbug commented Apr 19, 2016

zalox Apr 19, 2016

Choose a reason for hiding this comment

milleniumbug commented Apr 19, 2016 • edited Loading

zalox commented Apr 19, 2016

milleniumbug commented Apr 19, 2016

milleniumbug commented Apr 19, 2016

zalox commented Apr 19, 2016

eidheim commented Apr 19, 2016 • edited Loading

zalox commented Apr 19, 2016 • edited Loading

eidheim commented Apr 19, 2016

milleniumbug commented Apr 19, 2016 • edited Loading

zalox Apr 19, 2016

Choose a reason for hiding this comment

zalox commented Apr 19, 2016

eidheim commented Apr 20, 2016 • edited Loading

zalox commented May 26, 2016

eidheim commented May 26, 2016

zalox commented May 26, 2016

zalox commented Apr 4, 2016 •

edited

Loading

milleniumbug commented Apr 19, 2016 •

edited

Loading

eidheim commented Apr 19, 2016 •

edited

Loading

zalox commented Apr 19, 2016 •

edited

Loading

milleniumbug commented Apr 19, 2016 •

edited

Loading

eidheim commented Apr 20, 2016 •

edited

Loading