-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbundle OpenCV #111
base: master
Are you sure you want to change the base?
Unbundle OpenCV #111
Conversation
Dropping 106.900 lines from the repository, a greener compilation and more flexibility to compile against a different (= newer) version of OpenCV |
@drzraf If I remember correctly, this was mostly done for the Windows (and probably osX) Version. Could you test if these work still after bundled? |
In our SLProject we removed all prebuilt libraries within sub repositories. In the same step, we migrated the project to cmake. We now download the prebuilt libraries platform dependent from our server within the cmake generation step. |
if I understand correctly @l00mi, it would not be so much about Windows/OSX release (although binary releases needs testing before this get commited) but about Windows/OSX compilation, right? Indeed, with this commit, most OpenCV headers need to be provided by the host compiling Sadly, not using Windows nor OSX myself, I really can't help on this part. |
At the moment we link SLProject against opencv 3.4.1 with contributions. We provide prebuilt librararies for win64, macos, ios and android but not for linux. |
I have unbundled opencv in the ImagePlay Haiku port, maybe you can reuse my patches: |
OpenCV 3.1 headers were bundled.
Let's compile against OpenCV version provided by the system (eg: 3.4)