Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbundle OpenCV #111

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Unbundle OpenCV #111

wants to merge 5 commits into from

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Nov 1, 2018

OpenCV 3.1 headers were bundled.
Let's compile against OpenCV version provided by the system (eg: 3.4)

@drzraf
Copy link
Contributor Author

drzraf commented Nov 11, 2018

Dropping 106.900 lines from the repository, a greener compilation and more flexibility to compile against a different (= newer) version of OpenCV
RTBC?

@l00mi
Copy link
Member

l00mi commented Nov 16, 2018

@drzraf If I remember correctly, this was mostly done for the Windows (and probably osX) Version. Could you test if these work still after bundled?

@hsm4
Copy link
Contributor

hsm4 commented Nov 17, 2018

In our SLProject we removed all prebuilt libraries within sub repositories. In the same step, we migrated the project to cmake. We now download the prebuilt libraries platform dependent from our server within the cmake generation step.

@drzraf
Copy link
Contributor Author

drzraf commented Nov 17, 2018

if I understand correctly @l00mi, it would not be so much about Windows/OSX release (although binary releases needs testing before this get commited) but about Windows/OSX compilation, right?

Indeed, with this commit, most OpenCV headers need to be provided by the host compiling ImagePlay. While it's rather easy on on GNU/Linux, I don't know about Windows.
I understand that having a such a windows script to download headers and/or precompiled shared libraries could help windows-users who intend building.

Sadly, not using Windows nor OSX myself, I really can't help on this part.

@hudrima1
Copy link
Contributor

At the moment we link SLProject against opencv 3.4.1 with contributions. We provide prebuilt librararies for win64, macos, ios and android but not for linux.

@drzraf drzraf mentioned this pull request Apr 13, 2020
@extrowerk
Copy link

I have unbundled opencv in the ImagePlay Haiku port, maybe you can reuse my patches:
https://github.com/haikuports/haikuports/blob/14c2cab5428145b93232cb69683a67bbe68a9f06/media-gfx/imageplay/patches/imageplay-6.1.1%7Egit.patchset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants