Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of alternate Tailscale auth server #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmwagner18
Copy link

Hello, I have created a patch to allow use of Tailscale and a custom authentication server (such as Headscale). The readme has been updated to explain how to use a custom auth server and "normal" use should not be impacted (i.e. not entering anything in SDK Data for 'tsserver').

I would like to update the Tailscale readme further to detail ensuring that the subnet is accessible via the Tailnet but I'm struggling with this aspect. I created this issue regarding this. I would appreciate some help on this item so I can clarify the readme in the PR.

-Ben

@@ -1,5 +1,5 @@
[tailscale]
uuid = d4c47aa5-4409-4edf-bf1a-550182ad70a1
uuid = 9faa8914-d556-4c82-aec6-d536767d836f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the uuid is changed, this could affect uploading new versions to NCM correctly. Also, please increment the patch version

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies if I misread the docs- was updating the UUID unnecessary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for the sample code, do not change the UUID. When building locally you can distinguish that SDK apps are different by changing the UUID as mentioned in the docs. However, for this repo, since we are building the apps for the "Built Apps" page we want to keep the UUIDs consistent to prevent version mismatch issues.

Moreover, for every change to the sample code, the version should be incremented to also prevent version mismatch issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants