Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5GSPEED #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joncampo-cradlepoint
Copy link

Added 5GSPEED_DETAILED_ASSET SDK to the sdk sample. The 5GSPEED_DETAILED_ASSET allows users to initiate and get speedtest results by deleting the asset id column. It can also be automated by performing it using NCM API.

Copy link
Contributor

@dapplegatecp dapplegatecp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for this! The CI/CD on this will fail because the readme needs to be a readme.txt file (instead of readme.md, though we should probably change that requirement) Also it'll also fail because it wont find the app name in the main readme file, so you'll want to include those changes in your PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include the METADATA folder in the PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include this in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants