Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for registers A, B and D on the left side of indexed expressions #56

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

craigthomas
Copy link
Owner

This PR fixes an error with the following types of statements:

LDA  B,X

The symbol B for accumulator B was not being resolved correctly, and would result in a stacktrace of:

AttributeError: 'str' object has no attribute 'is_address_expression'

Registers can now be specified in the left hand side of indexed expressions correctly. Unit tests added to catch condition.

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #56 (46db033) into main (b48f996) will increase coverage by 0.03%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   82.43%   82.47%   +0.03%     
==========================================
  Files          11       11              
  Lines        1526     1529       +3     
==========================================
+ Hits         1258     1261       +3     
  Misses        268      268              
Impacted Files Coverage Δ
cocoasm/statement.py 90.24% <80.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48f996...46db033. Read the comment docs.

@craigthomas craigthomas merged commit f934e70 into main Mar 31, 2022
@craigthomas craigthomas deleted the indexed-register-fix branch March 31, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant