Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Harmonize imports of sqlalchemy module, use sa where applicable #10

Merged
merged 2 commits into from
Dec 21, 2023

Chore: Improve Ruff linter rules

3e3c6ec
Select commit
Loading
Failed to load commit list.
Merged

chore: Harmonize imports of sqlalchemy module, use sa where applicable #10

Chore: Improve Ruff linter rules
3e3c6ec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 21, 2023 in 1s

82.12% (-0.11%) compared to 2cfd7bb

View this Pull Request on Codecov

82.12% (-0.11%) compared to 2cfd7bb

Details

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (2cfd7bb) 82.23% compared to head (3e3c6ec) 82.12%.

Files Patch % Lines
target_cratedb/sinks.py 37.50% 10 Missing ⚠️
target_cratedb/connector.py 71.42% 4 Missing ⚠️
target_cratedb/tests/test_standard_target.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   82.23%   82.12%   -0.11%     
==========================================
  Files           7        7              
  Lines         681      677       -4     
==========================================
- Hits          560      556       -4     
  Misses        121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.