-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-built lib feature, and more bugfix for 2.3 #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazywhalecc
added
enhancement
New feature or request
kind/framework
Issues related to CLI app framework
mixed PR
This PR contains multiple updates
labels
Jul 7, 2024
… readline, unixodbc, xz pre-built libs
crazywhalecc
added
the
need test
This PR has not been tested yet, cannot merge now
label
Jul 12, 2024
crazywhalecc
changed the title
Add pre-built lib feature
Add pre-built lib feature, and more bugfix for 2.3
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
kind/framework
Issues related to CLI app framework
mixed PR
This PR contains multiple updates
need test
This PR has not been tested yet, cannot merge now
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #490
CI Updates
prefer-pre-built
option for manual triggered build actionsspc-max
for windows buildFramework Updates
bin/spc-alpine-docker
, addpkgroot
for Dockerfilepre-built.json
LibraryBase->setup(bool $force = false)
LibraryBase->getName()
(same as$lib::NAME
)LibraryBase->beforePack()
LibraryBase->install()
--ignore-cache-source
always working even if not specified--prefer-pre-built
fordownload
commanddev:pack-lib
(build and pack library as pre-built release)Config::getPreBuilt(string $name)
Downloader::getLatestGithubRelease(string $name, array $source, bool $match_result = true)
$lock_as
for download methodsuffix
for LicenseDumperDependency, PHP and Extension Updates
brotli,bip2,gmp,icu,libargon2,libavif,libcares,libevent,libiconv,liblz4,libpng,libsodium,libtiff,libwebp,libyaml,ncurses,onig,openssl,pkg-config,readline,sqlite,unixodbc,xz,zlib
icu,brotli,libargon2,libevent,libiconv,liblz4,ncurses,openssl
build files for pre-built libs${pcfiledir}/../..
Breaking Changes
BUILD_STATUS_xxx
->LIB_STATUS_xxx
BUILD_STATUS_FAILED
->LIB_STATUS_BUILD_FAILED
LIB_STATUS_INSTALL_FAILED
before-libs-extract
->before-lib[{lib_name}]-extract
after-libs-extract
->after-lib[{lib_name}]-extract
BuilderBase->buildLibs()
->BuilderBase->setupLibs()
CustomSourceBase->fetch(bool $force = false)
->CustomSourceBase->fetch(bool $force = false, ?array $config = null, int $lock_as = SPC_LOCK_SOURCE)
Checklist before merging
src/global/test-extensions.php
../docs/
.config/xxx.json
content, runbin/spc dev:sort-config xxx
.