Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto start services with docker #1020

Merged
merged 10 commits into from
Oct 22, 2024
Merged

fix: auto start services with docker #1020

merged 10 commits into from
Oct 22, 2024

Conversation

GHkrishna
Copy link
Contributor

@GHkrishna GHkrishna commented Oct 7, 2024 •
edited
Loading

What:

  • Add minimum changeable .env.sample for Platform and agent for starting services effortlessly (Especially, for provisioning the agent in the agent-provisioning service)
  • Initiating service with Docker with the docker-compose up file. This PR ensures that the platform will be able to start using docker
  • Add new services that have not been included in the dockerfile

@GHkrishna GHkrishna added bug Something isn't working enhancement New feature or request labels Oct 7, 2024
@GHkrishna GHkrishna self-assigned this Oct 7, 2024
@GHkrishna GHkrishna force-pushed the fix/auto-start-services-with-docker branch from e15a9c3 to 6593692 Compare October 11, 2024 12:50
@GHkrishna GHkrishna changed the title fix; auto start services with docker fix: auto start services with docker Oct 14, 2024
@GHkrishna
fix: add missing utility service in docker compose
3934bef 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
fix: attach agent-env to agent-provisioning
1f1f496 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
add agent.env
e1614dd 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
chore: minor fixes
76b0150 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
fix: agent-env string variables
317e770 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
fix: add agent env while starting agent using docker compose
bc32714 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
feat: add cloud-wallet services while docker-compose up
43893b0 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
chore: update docker compose to start agent while starting service us…
b1ed82a 
…ing npm

Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna GHkrishna force-pushed the fix/auto-start-services-with-docker branch from 2a88685 to b1ed82a Compare October 21, 2024 05:25
@GHkrishna GHkrishna marked this pull request as ready for review October 21, 2024 05:37
@GHkrishna GHkrishna linked an issue Oct 21, 2024 that may be closed by this pull request
fix: starting services with docker compose #1037
Open
8 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tipusinghaw
tipusinghaw approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bhavanakarwade
bhavanakarwade approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@bhavanakarwade bhavanakarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@GHkrishna GHkrishna merged commit 47d704d into develop Oct 22, 2024
2 checks passed
@GHkrishna GHkrishna deleted the fix/auto-start-services-with-docker branch October 22, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@bhavanakarwade bhavanakarwade bhavanakarwade approved these changes

Assignees

@GHkrishna GHkrishna

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: starting services with docker compose
3 participants
@GHkrishna @tipusinghaw @bhavanakarwade