Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing a general support for native JSON serialization. #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Introducing a general support for native JSON serialization. #194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538241f
Introducing a general support for native JSON serialization.
bucefal91 Aug 19, 2018
7013441
Fixing coding standards!
bucefal91 Aug 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/CrEOF/Spatial/PHP/Types/AbstractGeometry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
* @author Derek J. Lambert <[email protected]>
* @license http://dlambert.mit-license.org MIT
*/
abstract class AbstractGeometry implements GeometryInterface
abstract class AbstractGeometry implements GeometryInterface, \JsonSerializable
{
/**
* @var int
Expand Down Expand Up @@ -65,6 +65,14 @@ public function toJson()
return json_encode($json);
Copy link

@tugrul tugrul Jun 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can replace to:

public function toJson()
{
    return json_encode($this);
}

}

/**
* @return array
*/
public function jsonSerialize()
{
return $this->toArray();
Copy link

@tugrul tugrul Jun 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also type should be in the json data to make compatible to GeoJSON spec. Better implementation:

public function jsonSerialize()
{
    return ['type' => $this->getType(), 'coordinates' => $this->toArray()];
}

}

/**
* @return null|int
*/
Expand Down