Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle WPS endpoint identifiers with processID:revision #800

Merged
merged 11 commits into from
Mar 5, 2025

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Feb 25, 2025

Description

To Do

  • Add tests
    • single processID when it is the latest revision
    • single processID:revision when it is the latest
    • single processID:revision when it is an older revision
    • multi processID:revision,processID:revision,processID with mixture of latest/older revisions

@fmigneault fmigneault self-assigned this Feb 25, 2025
@github-actions github-actions bot added process/wps3 Issue related to WPS 3.x (REST-JSON) processes support ci/doc Issue related to documentation of the package feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. labels Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (760c115) to head (cde4ad5).
Report is 12 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
weaver/processes/execution.py 95.00% 1 Missing ⚠️
weaver/wps/service.py 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
+ Coverage   87.72%   87.76%   +0.03%     
==========================================
  Files          82       82              
  Lines       21294    21346      +52     
  Branches     2886     2893       +7     
==========================================
+ Hits        18681    18734      +53     
+ Misses       1852     1851       -1     
  Partials      761      761              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support labels Feb 26, 2025
@fmigneault fmigneault marked this pull request as ready for review February 28, 2025 06:29
@fmigneault fmigneault merged commit 0737ced into master Mar 5, 2025
47 checks passed
@fmigneault fmigneault deleted the fix-wps-proc-id-rev branch March 5, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when executing an older version of a process
2 participants