Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make re2 an optional peer dependency #34

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

aldenquimby
Copy link
Contributor

@aldenquimby aldenquimby commented Nov 21, 2024

Fixes #33

Verified as follows:

npm run test

npm uninstall re2

npm run test

As of npm 8+, peer dependencies are automatically installed, so this should not impact consumers by default.

But anyone that wants to explicitly exclude re2 from their build process can now do so without this lib crashing.

@alexturpin
Copy link

It would be great to see either this or #35 accepted!

@baptistejamin baptistejamin merged commit d0be7a5 into crisp-oss:master Jan 13, 2025
@baptistejamin
Copy link
Contributor

Thank you for the merge request, it has been merged and made available in 1.9.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Consider making re2 an optional dependency?
3 participants