-
-
Notifications
You must be signed in to change notification settings - Fork 105
Feat: Perplexity support #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: Perplexity support #42
Conversation
Please, let me know if there is something missing on this first implementation Question: How can I run tests locally? |
@joaoGabriel55 I started a pull request here. Do you want to either tweak what I have, or incorporate my changes into your branch? |
@adenta let me know if there is something to improve |
@gquaresma-godaddy we need tests! Want to take a crack at it? |
Sure! I will work on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. It looks like sonar
has support for vision, so it would need to be added to the chat_content_spec
vision test, and the chat_streaming_spec
.
Two new features to consider in your provider implementation:
|
Added configuration requirements handling in 75f99a1 Each provider now specifies what configuration is required via a simple
Example of the new error messages: RubyLLM::ConfigurationError: anthropic provider is not configured. Add this to your initialization:
RubyLLM.configure do |config|
config.anthropic_api_key = ENV['ANTHROPIC_API_KEY']
end |
@joaoGabriel55 is this still on your radar? I'd love to merge Perplexity support soon. Whenever you're ready, could you resolve the conflicts and request a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work!
It looks generally good, I just need some changes and tests. Please pick the cheapest model to test with.
Issue
#20
Description
This PR consists on add Perplexity API support