86: Add default limit for tools completions #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhys117
commented
Apr 1, 2025
lib/ruby_llm/chat.rb
Outdated
| @@ -105,6 +107,10 @@ def handle_tool_calls(response, &) | |||
| end | |||
|
|
|||
| def execute_tool(tool_call) | |||
| raise ToolCallsLimitReachedError, "Tool calls limit reached: #{@max_tool_calls}" if max_tool_calls_reached? | |||
There was a problem hiding this comment.
It might be worth discussing if this should be handled via the chat instead of raising an unhandled error.
- Otherwise the chat object could not have 'ask' executed on again due to malformed messages
rhys117
changed the title
crmne
requested changes
Apr 23, 2025
lib/ruby_llm.rb
Outdated
Comment on lines
33
to
34
| def chat(model: nil, provider: nil) | ||
| Chat.new(model: model, provider: provider) | ||
| def chat(model: nil, provider: nil, max_tool_completions: config.max_tool_completions) | ||
| Chat.new(model: model, provider: provider, max_tool_completions: max_tool_completions) |
There was a problem hiding this comment.
changing the whole interface to chat is a bit heavy handed. this should be a simple config change.
There was a problem hiding this comment.
Thanks for the feedback @crmne. I've adjusted things so the chat interface isn't modified, and instead, a single instance can use an override from the config using with_max_tool_completions.
Please let me know what you think?
There was a problem hiding this comment.
@crmne would love an update here ... I'm getting looping tool calls as well, and would like to avoid implementing my own solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #86
Purpose
Introduces a configurable limit on tool completions to prevent infinite loops and excessive API usage. This feature adds protection against scenarios where AI responses might trigger continuous tool calls.
Implementation Details
max_tool_completionsconfiguration option (default: 25 calls)RubyLLM.chat.with_max_tool_completions(N)ToolCallCompletionsReachedErrorwhen limit is exceedednumber_of_tool_completionscounternilUsage Example
Testing
Documentation
TODO