fix(cluster): Cluster fails to delete (#87) #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This just implements the recommendation by @stevendborrelli. Which fixes the issue of Cluster Objects not being deleted within ArgoCD, when the Cluster Resource is deleted.
Fixes #87
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I ran
make buildand deployed the provider in a cluster with crossplane deployed.A Cluster resource was created and I verified that it was created successfully using
argocd cluster listand by viewing the status ofkubectl get clustersthen deleted the resource and verified that it was deleted in argocd using the sameargocd cluster listcommand.