Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): Add missing GLACIER_IR storage type in replication and lifecycle Configuration types #2125

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

geoffreyme
Copy link
Contributor

Hello,

It's currently not possible to create a bucket with GLACIER_IR as a replicationConfiguration storageClass:

The Bucket "my-test-bucket-mxapp-bucket" is invalid: spec.forProvider.replicationConfiguration.rules[0].destination.storageClass: Unsupported value: "GLACIER_IR": supported values: "STANDARD", "GLACIER", "STANDARD_IA", "ONEZONE_IA", "INTELLIGENT_TIERING", "DEEP_ARCHIVE"

Description of your changes

As per https://docs.aws.amazon.com/AmazonS3/latest/API/API_Transition.html and https://docs.aws.amazon.com/AmazonS3/latest/API/API_NoncurrentVersionTransition.html GLACIER_IR should be part of the NoncurrentVersionTransition and Transition types for the lifecycle and replication configurations.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • make reviewable test
  • Applied generated CRD in a dedicated cluster, bucket created with GLACIER_IR as destination Storage Class.

Thanks for reviewing, please let me know if something is missing for the MR.

…ycle Configuration types

Signed-off-by: Geoffrey Mersch <[email protected]>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @geoffreyme!

@MisterMX MisterMX merged commit dbcd2f2 into crossplane-contrib:master Nov 27, 2024
8 of 9 checks passed
Copy link

Successfully created backport PR #2130 for release-0.50.

@geoffreyme
Copy link
Contributor Author

Thanks for your quick review @MisterMX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants